[llvm-commits] Fix internalize in the case where no symbols are needed

[Duncan Sands]

Hi Rafael,

> What about the attached patch? I implemented your suggestions and
> added a -std-link-opts test.

looks good to me except for this typo:

> --- a/lib/Transforms/IPO/Internalize.cpp
> +++ b/lib/Transforms/IPO/Internalize.cpp
> @@ -7,9 +7,9 @@
>  //
>  //===----------------------------------------------------------------------===//
>  //
> -// This pass loops over all of the functions in the input module, looking for a
> -// main function.  If a main function is found, all other functions and all
> -// global variables with initializers are marked as internal.
> +// This pass loops over all of the functions and variables in the input module.
> +// If the function or variable ss not in the list of external names given to

variable ss not -> variable is not

> +// the pass it is marked as internal.
>  //
>  //===----------------------------------------------------------------------===//
>

I reckon you should run the nightly testsuite before committing though.

Ciao, Duncan.