[llvm-commits] [PATCH] Test cases for constant gep's with various address spaces.

[Chandler Carruth]

  You haven't addressed my comments yet, but you have added a *substantial* amount of code to what was originally a small patch. It is now over 1k lines. Don't do this. If you increase the size of a review once it has begun, expect the review time to increase essentially exponentially.

  1) Break this apart into small chunks that are easier to review.
  2) Address the comments I already made.
  3) Update this review with the first chunk. No more.

  One further meta-level comment: As the number of test cases grow, the importance of having comments attached to them to clarify what it is your testing grows. Wer'e up to 300 lines of test case, and so you need to be really clear for future maintainers what is expected of them.

http://llvm-reviews.chandlerc.com/D79