[llvm-commits] [lld] r166700 - in /lld/trunk: lib/ReaderWriter/ELF/CMakeLists.txt lib/ReaderWriter/ELF/HexagonReference.cpp lib/ReaderWriter/ELF/PPCReference.cpp lib/ReaderWriter/ELF/ReferenceKinds.cpp lib/ReaderWriter/ELF/ReferenceKinds.h lib/Re

Eric Christopher echristo at gmail.com
Thu Oct 25 11:05:02 PDT 2012


> This patch changes the following:
>   * Use conventional naming for KindHandlers.
>   * Add X86 relocation routines.
>   * Use std::function instead of function pointers in _fixupHandler map.
>   * Change _fixupHandler map from std::map to llvm::DenseMap.
>   * Add simple testcase for x86 relocations.
>

In general the llvm convention is to make a set of small changes
rather than one large change. In this case each one of these (minus
the testcase which obviously goes with adding the relocations) could
have gone in separately and much more obviously.

-eric



More information about the llvm-commits mailing list