[llvm-commits] Fixing Bug 13662: paired register for inline asm with 64-bit data on ARM

[Weiming Zhao]

Hi Jakob,

Attached is the next patch that uses GPR Pair to replace the hard coded
R0/R1, R2/R3 in the ldrexd/strexd intrinsics, respectively.
I tested it (alone with the previous patch) against the existing unit tests
(test/CodeGen/ARM/ldstrexd.ll), no problem. 

Please help to review it.

Thanks,
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


-----Original Message-----
From: Weiming Zhao [mailto:weimingz at codeaurora.org] 
Sent: Tuesday, October 23, 2012 2:57 PM
To: 'Jakob Stoklund Olesen'
Cc: 'Jim Grosbach'; 'llvm-commits at cs.uiuc.edu'; 'zinob at codeaurora.org'
Subject: RE: [llvm-commits] Fixing Bug 13662: paired register for inline asm
with 64-bit data on ARM

Sorry about that.
When I run "make check", even without my patch, I still see 93 unexpected
failures. So maybe I ignored that failure.

Anyway, I think it's because an omitting of "else" at line 1000 of
ARMBaseInstrInfo.cpp.
I fixed it. Sorry again for the mistake.

Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


-----Original Message-----
From: Jakob Stoklund Olesen [mailto:stoklund at 2pi.dk] 
Sent: Tuesday, October 23, 2012 2:19 PM
To: weimingz at codeaurora.org
Cc: 'Jim Grosbach'; llvm-commits at cs.uiuc.edu; zinob at codeaurora.org
Subject: Re: [llvm-commits] Fixing Bug 13662: paired register for inline asm
with 64-bit data on ARM


On Oct 22, 2012, at 2:22 PM, Weiming Zhao wrote:

> Great.
> Will this patch be committed alone or wait till all patches are ready?

When I tried applying your patch, I got test failures and crashes.

/jakob

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-GPR-Pair-constraint-to-replace-hard-coded-regist.patch
Type: application/octet-stream
Size: 6247 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121024/d63b9e64/attachment.obj>