[llvm-commits] [PATCH] PowerPC: More support for Altivec compare operations

[Hal Finkel]

----- Original Message -----
> From: "Adhemerval Zanella" <azanella at linux.vnet.ibm.com>
> To: llvm-commits at cs.uiuc.edu
> Sent: Wednesday, October 24, 2012 9:49:42 AM
> Subject: [llvm-commits] [PATCH] PowerPC: More support for Altivec compare operations
> 
> My previous patch for altivec compare support was incomplete, it
> didn't handle
> the other operators (!=, <, >, etc.). This patch add a better and
> more complete
> support for comparisons for altivec supported types (v16i8, v8i16,
> v4i32, and
> v4f32).
> 
> The testcase also covers all the supported comparison operators for
> the altivec
> types.
> 
> Any tips, suggestions, comments?

I think this looks good. A few small things:

+    SDValue VSET0(CurDAG->getMachineNode(PPC::V_SET0, dl, VecVT), 0);
+    SDValue VMASK(CurDAG->getMachineNode(VSPLATInst, dl, VecVT, getI32Imm(-1)), 0);
...
+        SDValue VCMP(CurDAG->getMachineNode(VCMPInst, dl, VecVT, LHS, RHS), 0);

These variable names (and several others like them), don't really seem to following the naming rules in the coding conventions. VSet0, VMask, VCmp, etc. might be more conforming.

   %sext = sext <8 x i1> %cmp to <8 x i32>
   %0 = bitcast <8 x i32> %sext to <8 x float>
-  ret <8 x float> %0
+ ret <8 x float> %0
 }

Is this a bogus indentation change?

Thanks again,
Hal

> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory