[llvm-commits] LLD Add x86 relocation reference code

[Sid Manning]

On 10/22/12 16:39, Michael Spencer wrote:
> On Fri, Oct 19, 2012 at 3:15 PM, Sid Manning<sidneym at codeaurora.org>  wrote:
>>
>> This attached change does the following:
>>    * Moves x86 content from ReferenceKinds.cpp to a new file,
>> x86Reference.cpp
>>    * Adds support for R_386_32 and R_386_PC32 relocs
>>    * Includes simple testcase
>>
>>
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
>> The Linux Foundation
>
> The filename should be X86Reference.cpp.
>
> Also the class should be X86KindHandler (arch name goes first
> everywhere else in llvm).
>
> The relocation handlers should be named relocNONE, relocPC32, etc...

I made the above name changes and change PPC and Hexagon too so this 
contains two attachments.  One, "rename.diff" that rename the code that 
is currently in svn and two, "add-x86-ref-support2.diff" that includes 
the name changes and other concerns.

>
>> +  std::map<int32_t,
>> +           int (*)(uint8_t *location, uint64_t fixupAddress,
>> +                   uint64_t targetAddress, uint64_t addend)>  _fixupHandler;
>
> This should probably use std::function.
OK.

>
> - Michael Spencer

Thanks,

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rename.diff
Type: text/x-patch
Size: 13725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121024/81779e22/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-x86-ref-support2.diff
Type: text/x-patch
Size: 9593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121024/81779e22/attachment-0001.bin>