[llvm-commits] Patch to update DataLayout code

Eli Friedman eli.friedman at gmail.com
Wed Oct 24 10:53:42 PDT 2012


On Wed, Oct 24, 2012 at 10:51 AM, Villmow, Micah <Micah.Villmow at amd.com> wrote:
> I believe there are other parts of the code base that can be cleaned up with this API, especially once the vector of pointer support with different address spaces gets fully propagated. This is just the one location where it was especially egregious in my original patch.

Okay.

-Eli

>> -----Original Message-----
>> From: Eli Friedman [mailto:eli.friedman at gmail.com]
>> Sent: Wednesday, October 24, 2012 10:48 AM
>> To: Villmow, Micah
>> Cc: llvm-commits at cs.uiuc.edu
>> Subject: Re: [llvm-commits] Patch to update DataLayout code
>>
>> On Wed, Oct 24, 2012 at 10:40 AM, Villmow, Micah
>> <Micah.Villmow at amd.com> wrote:
>> > Here is a patch to cleanup the DataLayout patch.
>>
>> Is getPointerTypeSizeInBits really worth adding, given it has exactly
>> one caller?
>>
>> Otherwise, fine.
>>
>> -Eli
>
>




More information about the llvm-commits mailing list