[llvm-commits] [llvm] r166475 - /llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp

[Duncan Sands]

Hi David,

On 23/10/12 17:22, David Blaikie wrote:
> On Tue, Oct 23, 2012 at 2:07 AM, Duncan Sands <baldrick at free.fr> wrote:
>> Author: baldrick
>> Date: Tue Oct 23 04:07:02 2012
>> New Revision: 166475
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=166475&view=rev
>> Log:
>> Fix typo that somehow escaped both testing and code inspection.
>
> Is it at all practical to figure out what test coverage was missing & add it?

I've synthesized a testcase that would have caught this, see commit 166547.

Ciao, Duncan.

>
>>
>> Modified:
>>      llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp
>>
>> Modified: llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp?rev=166475&r1=166474&r2=166475&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp (original)
>> +++ llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp Tue Oct 23 04:07:02 2012
>> @@ -965,7 +965,7 @@
>>           continue;
>>         }
>>
>> -      if (Cast->getOperand(0)) {
>> +      if (Cast->getOpcode() == Instruction::Trunc) {
>>           // Op is truncated from a larger type, descale in the larger type.
>>           // Suppose Op = trunc X, and we descale X as Y * sext Scale.  Then
>>           //   trunc (Y * sext Scale) = (trunc Y) * Scale
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits