[llvm-commits] [PATCH] Teach llvm-objdump to dump Win64 exception tables

[Michael Spencer]

On Mon, Oct 22, 2012 at 7:49 AM, Kai <kai at redstar.de> wrote:
> Hi João,
>
> the line length should be fixed now, too.
>
>
> Regards
> Kai
> On 22.10.2012 16:24, João Matos wrote:
>>
>> Could you attach the "Win64EH.h" field size-related fixes as a separate
>> patch? Ideally those should be in their own commit as they're
>> independent from the rest of the patch.
>>
>> The dumping functionality looks good to me and I've been using them
>> locally for a while. There's just some lines in there that are too long
>> and should be wrapped as to LLVM coding standards.
>>
>>
>> On Mon, Oct 22, 2012 at 3:09 PM, Kai
>> <kai at redstar.de <mailto:kai at redstar.de>> wrote:
>>
>>     Hi!
>>
>>     This patch is an extended version of the patch posted by João Matos
>>     some time ago. It adds a new option 'unwind-info' to llvm-objdump.
>>     It is then possible to dump Win64 SEH tables. This is a great
>>     debugging help if you dig into Win64 exception support. Output
>> example:
>>
>>     Function Table:
>>        Start Address: main$filt$0
>>        End Address: main$filt$0 + 0x0015
>>        Unwind Info Address: $unwind$main$filt$0
>>        Size of prolog: 6
>>        Number of Codes: 2
>>        No frame pointer used
>>        Unwind Codes:
>>          0x06: UOP_AllocSmall 32
>>          0x02: UOP_PushNonVol RBP
>>
>>     Please review and commit if it looks good.
>>
>>     Regards
>>     Kai
>>
>>
>>     _______________________________________________
>>     llvm-commits mailing list
>>     llvm-commits at cs.uiuc.edu
>>     <mailto:llvm-commits at cs.uiuc.edu>
>>
>>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>>
>>
>> --
>> João Matos
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

This needs tests, and PrintCOFFUnwindInfo and friends should be moved
into a separate translation unit (COFFDump.cpp).

With that it looks good.

- Michael Spencer