[llvm-commits] [llvm] r166239 - in /llvm/trunk/test/BugPoint: crash-narrowfunctiontest.ll metadata.ll remove_arguments_test.ll

[Rafael Espíndola]

>> Is this failing on MachO? Could you at least make this hack MachO only?
>
> Yes, it is failing for Mach-O.  Since it's a temporary workaround, and since it is only XFAILed when building bugpoint with LTO, it didn't seem necessary to also restrict this to be for Mach-O only.  Are you OK with that until we get LTO fixed?

It depends. What is the root cause? If this is a big bug in libLTO
that just happens to be hidden for ELF? If so, this is the right
temporary workaround. If, on the other hand, it is a problem with the
linker (like not calling lto_codegen_add_must_preserve_symbol when it
should), then I think this should be made Mach-O only, or even better,
old linker only.

Cheers,
Rafael