[llvm-commits] [llvm] r166224 - in /llvm/trunk: docs/TestingGuide.html utils/lit/lit/ExampleTests/xfail-feature.c utils/lit/lit/TestRunner.py

[Daniel Dunbar]

On Fri, Oct 19, 2012 at 12:30 AM, Duncan Sands <baldrick at free.fr> wrote:
> Hi Daniel,
>
>
>> lit: Allow XFAIL: lines to also refer to "features".
>
>
> does this mean that the hack for valgrind of tacking -vg on the end is not
> needed any more?

Good question, I will look into that.

>
>
>> --- llvm/trunk/docs/TestingGuide.html (original)
>> +++ llvm/trunk/docs/TestingGuide.html Thu Oct 18 15:43:04 2012
>> @@ -798,14 +798,15 @@
>>     <p>Sometimes it is necessary to mark a test case as "expected fail" or
>> XFAIL.
>>     You can easily mark a test as XFAIL just by including <tt>XFAIL: </tt>
>> on a
>>     line near the top of the file. This signals that the test case should
>> succeed
>> -  if the test fails. Such test cases are counted separately by the
>> testing tool. To
>> -  specify an expected fail, use the XFAIL keyword in the comments of the
>> test
>> -  program followed by a colon and one or more regular expressions
>> (separated by
>> -  a comma). The regular expressions allow you to XFAIL the test
>> conditionally by
>> -  host platform. The regular expressions following the : are matched
>> against the
>> -  target triplet for the host machine. If there is a match, the test is
>> expected
>> -  to fail. If not, the test is expected to succeed. To XFAIL everywhere
>> just
>> -  specify <tt>XFAIL: *</tt>. Here is an example of an <tt>XFAIL</tt>
>> line:</p>
>> +  if the test fails. Such test cases are counted separately by the
>> testing
>> +  tool. To specify an expected fail, use the XFAIL keyword in the
>> comments of
>> +  the test program followed by a colon and one or more failure patterns.
>> Each
>> +  failure pattern can be either '*' (to specify fail everywhere), or a
>> part of a
>> +  target triple (indicating the test should fail on that platfomr), or
>> the name
>
>
> platfomr -> platform

Fixed.

>> +  of a configurable feature (for example, "loadable_module").. If there
>> is a
>
>
> Two full stops after closing parenthesis.

Fixed.

Thanks,
 - Daniel

>> +  match, the test is expected to fail. If not, the test is expected to
>> +  succeed. To XFAIL everywhere just specify <tt>XFAIL: *</tt>. Here is an
>> +  example of an <tt>XFAIL</tt> line:</p>
>>
>>   <div class="doc_code">
>>   <pre>
>
>
> Ciao, Duncan.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits