[llvm-commits] [patch][pr14113] Use inreg in combination with x86_fastcallcc

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Oct 19 08:01:17 PDT 2012


> (Note to anyone else reviewing: don't compare against gcc 4.2; gcc's
> behavior changed in 4.3.)
>
> Please add a testcase for something like "void bar5(struct S2 y, int
> z) {}", with S2 from your testcase.  Please add a testcase with an
> argument which is a C++ struct with a non-trivial copy constructor.
> Please add testcases involving sret.

Thanks for the suggestions. This found a bug in regparm too!

> This change is going to break any other sources of IR which expect the
> current behavior of x86_fastcall; at the very least, please start a
> thread on llvmdev so this doesn't surprise anyone.

A new patch is attached, I will start a thread on llvmdev about the
representation.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: application/octet-stream
Size: 2530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121019/56a2063d/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 16645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121019/56a2063d/attachment-0001.obj>


More information about the llvm-commits mailing list