[llvm-commits] [llvm] r166205 - /llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp

Sameer Sahasrabuddhe sameer.sahasrabuddhe at amd.com
Thu Oct 18 20:37:14 PDT 2012


On Thu, 18 Oct 2012 13:11:45 -0700
David Blaikie <dblaikie at gmail.com> wrote:

> > Should this be 'isIdentifiedSafeObject()' ?
> >                   ^ uppercase
> 
> "Function names should be verb phrases (as they represent actions),
> and command-like function should be imperative. The name should be
> camel case, and start with a lower case letter (e.g. openFile() or
> isFoo())."
> 
>  -
> http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly

>From the same reference:

  "Type names (including classes, structs, enums, typedefs, etc) should
   be nouns and start with an upper-case letter (e.g. TextFileReader)."

The pass itself needs to be renamed to "LoopVectorizer".

Sameer.





More information about the llvm-commits mailing list