[llvm-commits] Patch to generalize .weak_definition directive in MCAsmStreamer

[Jim Grosbach]

Seems reasonable, but please make sure there's existing test cases for the default format (to make sure this doesn't regress those) and add a new test case for NVPTX to make sure we do it right for that (probably in test/CodeGen/NVPTX).

-Jim

On Oct 18, 2012, at 4:47 PM, "Dmitry N. Mikushin" <maemarcus at gmail.com> wrote:

> Dear all,
> 
> In NVPTX backend it is illegal to generate .weak_definition directive
> in its default format. In order to let the target provide its own
> implementation of this directive, MCAsmStreamer should emit
> MAI.getWeakDefDirective() instead of hard-coded
> "\t.weak_definition\t", in the same way as it is already done for
> .globl/.global.
> 
> Please see the attached patch.
> 
> Thanks,
> - D.
> <weak_definition.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits