[llvm-commits] Patch to add address space support to getIntPtrTy

[Villmow, Micah]

Sorry about that, trying to remove the spaces at end of line caught some mostly harmless changes. I've fixed them in this patch.

Should I send the whitespace changes in another patch? Or should they always be ignored?

> -----Original Message-----
> From: Eli Friedman [mailto:eli.friedman at gmail.com]
> Sent: Thursday, October 18, 2012 3:37 PM
> To: Villmow, Micah
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Patch to add address space support to
> getIntPtrTy
> 
> On Thu, Oct 18, 2012 at 3:12 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> > I've attached a new patch, and I've also added the test case which
> fails without this change. There were a few places where I didn't know
> what to change and my original guess was wrong, so I added FIXME's to
> those locations. Another thing I think will make these patches better
> is by adding a new interface of getIntPtrTy(). Currently it is
> getIntPtrTy(LLVMContext, unsigned) and usually the context and the AS
> come from the same Value*, so I'm wondering if adding
> getIntPtrTy(Value*) would be useful.
> 
> -
> +
> 
> Please don't send patches with changes like this.
> 
> -Eli

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 002-per-address-space-get-int-ptr-type-patch.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121018/1c3c41fe/attachment.txt>