[llvm-commits] [ARM] Extra frame for non-VA byval parameter

[Stepan Dyatkovskiy]

Hi Manman,

manman ren wrote:
>
> On Oct 17, 2012, at 11:50 AM, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:
>
>> We invoke VarArgsStyleRegisters for the first byval argument only. If I got right its memory part starts with ArgOffset = 0 always. I inserted assertion "VA.getLocMemOffset() == 0" at the beginning of this branch just for belaying.
>> Though is there any hypotetical cases where it may fail?
> What if we have lots of scalars before the first byval argument such that the first byval argument will not start at offset 0?
> VARegSaveSize will probably be zero for that case, and we will fall to the else clause in VarArgsStyleRegisters.
Of course, it couses improper behaviour. I fixed patch and reattached it.
-Stepan.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: byval-frame-fix.patch
Type: text/x-patch
Size: 2933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121018/4b654ff3/attachment.bin>