[llvm-commits] Add scope support for Absolute symbols

Shankar Easwaran shankare at codeaurora.org
Wed Oct 17 22:47:43 PDT 2012


On 10/17/2012 5:38 PM, Shankar Easwaran wrote:
> On 10/17/2012 10:17 AM, Sid Manning wrote:
>>
>> Add support for this cases where absolute symbols binding types. This 
>> is the example:
>>
>> .globl absSymbol
>> .set absSymbol,0xC0000
>> .type absSymbol, @object
>>
>> .local absSymbol2
>> .set absSymbol2,0xD0000
>> .type absSymbol2, @object
>>
>> This patch changes the following:
>>   * Moves enum Scope from DefinedAtom.h to Atom.h
> Can the enumeration be moved back to DefinedAtom, because the scope 
> attributes are associated mainly with DefinedAtoms and AbsoluteAtoms.
>
> Otherwise the patch looks ok with me.
>
Pls ignore this review comment. Looks ok with me.

Shankar Easwaran
Qualcomm Innovation Center.



More information about the llvm-commits mailing list