[llvm-commits] [PATCH, PowerPC] Fix int-to-fp double-rounding errors

[Jim Grosbach]

On Oct 17, 2012, at 12:06 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> 
> 
> ----- Original Message -----
>> Hal Finkel <hfinkel at anl.gov> wrote on 17.10.2012 16:57:45:
>> 
>>> Please also include a regression test (in test/CodeGen/PowerPC). In
>>> addition, can you please include a more in-depth explanation of the
>>> associated math; this currently introduces a bunch of "magic
>>> numbers" (2047, etc.) which seem non-obvious.
>> 
>> Here's an updated version of the patch that adds a test case
>> and some more comments. Is this OK?
> 
> +; RUN: llc -mcpu=pwr7 -enable-unsafe-fp-math < %s | not grep isel
> 
> Please don't use grep in the tests, only FileCheck (I know that a bunch of the old tests use grep, but my understanding is that we're trying to move away from that).

That's correct.

> You can put in a CHECK-NOT: isel
> 
> Otherwise, LGTM.
> 
> Thanks again,
> Hal
> 
>> 
>> Thanks,
>> Ulrich
>> 
>> (See attached file: diff-llvm-sitofp-doublerounding)
> 
> -- 
> Hal Finkel
> Postdoctoral Appointee
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits