[llvm-commits] [PATCH] LoopVectorizer

[Nadav Rotem]

On Oct 17, 2012, at 6:20 AM, "Rao, Shivarama" <Shivarama.Rao at amd.com> wrote:

> Hi Nadav,
> 
> Some minor comments:
> 
> a) Some functions such as isConsecutiveGep, runOnLoop are inlined within the class. It will be good to see them defined outside.
> 
Done.

> b) The function CopyEmptyLoop can renamed to createEmptyLoop for better meaning of the function.
> 
> c) There are some inconsistencies in function name declarations. The functions CopyEmptyLoop, VectorizeLoop, DeleteOldLoop and ScalarizeInstructions are not consistent with getConsecutiveVector,isConsecutiveGep (first leter).  They can be made consistent.
> 

Done.

> d) Do we need to take any extra care of intrinsic calls?. In the current code, I guess they will be handled in ScalarizeInstruction function and I am not sure how they work. You can have a look on this.
> 
Yes. We would like to vectorize intrinsics and function calls. But we needed to start with regular functions :)


> Regards,
> Shivaram
> 
>