[llvm-commits] [PATCH] LoopVectorizer

[Rao, Shivarama]

Hi Nadav,

Some minor comments:

a) Some functions such as isConsecutiveGep, runOnLoop are inlined within the class. It will be good to see them defined outside.

b) The function CopyEmptyLoop can renamed to createEmptyLoop for better meaning of the function.

c) There are some inconsistencies in function name declarations. The functions CopyEmptyLoop, VectorizeLoop, DeleteOldLoop and ScalarizeInstructions are not consistent with getConsecutiveVector,isConsecutiveGep (first leter).  They can be made consistent.

d) Do we need to take any extra care of intrinsic calls?. In the current code, I guess they will be handled in ScalarizeInstruction function and I am not sure how they work. You can have a look on this.

Regards,
Shivaram