[llvm-commits] [PATCH] lli memory manager does not ensure proper alignment

[Amara Emerson]

Good find. I've attached a new patch that hopefully fixes that issue, it
uses RoundUpToAlignment() as well.

Amara

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: 12 October 2012 14:01
To: Amara Emerson
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] lli memory manager does not ensure
proper alignment

>> Also, I think the amount calculation is dodgy. Suppose Size=1 and
>> Alignment=16. It would then ask for 16 bytes. But if a misaligned
>> address was returned, it would align it up to the end of the block and
>> use incorrect memory for the single byte.
>
> Actually, ignore that. I forgot that the memory past the alignment
> sentinal is good.

But not good enough! Mwahahahaha! Size=15 and Align=16 still goes
wrong, I think.

Tim. (who may get it right one of these days).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lli-align-datasection-revised1.patch
Type: application/octet-stream
Size: 1268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121012/df6a067d/attachment.obj>