[llvm-commits] [PATCH, test-suite, AltiVec][1/4] Support building with FSF GCC

[Hal Finkel]

----- Original Message -----
> From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> To: llvm-commits at cs.uiuc.edu
> Sent: Friday, October 12, 2012 7:25:54 AM
> Subject: [llvm-commits] [PATCH, test-suite,	AltiVec][1/4] Support building with FSF GCC
> 
> 
> Hello,
> 
> all tests under SingleSource/UnitTests/Vector/Altivec/ failed for me,
> because they did not even compile under the Linux system compiler.
>   It
> turns out those tests use a number of features that had never been
> supported by any FSF GCC release (or a Linux distribution compiler
> based on
> those), only on certain GCC builds provided by Apple:
> 
> - The compiler flag -faltivec
>   (FSF GCC only supports -maltivec.)
> 
> - Vector initializer syntax using parentheses
>   (FSF GCC only supports the syntax using braces.)
> 
> The attached patch changes the test case sources and Makefiles to
> replace
> those features by the equivalent ones supported by FSF GCC.  Since
> clang
> already supports both versions, there should be no change there.
>  (Also, I
> think Apple's PowerPC GCC supports both variants as well, so this
> shouldn't
> be an issue either.)
> 
> Would this approach be OK?

LGTM. clang is supposed to have support for the AltiVec syntax extensions, but the splat-with-parens feature can certainly be covered by a clang regression test (and I assume that it already is).

 -Hal

> 
> Bye,
> Ulrich
> 
> (See attached file: diff-testsuite-altivec-gcc)
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory