[llvm-commits] [PATCH, test-suite, AltiVec][2/4] Fix pre-ANSI C

[Hal Finkel]

----- Original Message -----
> From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> To: llvm-commits at cs.uiuc.edu
> Sent: Friday, October 12, 2012 7:26:03 AM
> Subject: [llvm-commits] [PATCH, test-suite, AltiVec][2/4] Fix pre-ANSI C
> 
> 
> Hello,
> 
> when building alti.stepfft.c, clang errors out with "conflicting
> types
> for ..." several functions, because they have been used without
> prototypes
> visible  (in fact, that source file partially still uses K&R style
> function
> definitions).  In other files (notably alti.expandfft.c, which
> contains
> very similar code), prototypes have already been provided.
> 
> Therefore, the patch below fixes the compilation failure by providing
> prototypes for all functions in alti.stepfft.c as well.
> 
> OK to commit?

I think this is fine. Out of curiosity, do all relevant compilers (that understand AliVec) also understand __complex__, or should we change to the C99 _Complex keyword)?

 -Hal

> 
> Bye,
> Ulrich
> 
> 
> (See attached file: diff-testsuite-altivec-proto)
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory