[llvm-commits] Patch to add support for SPIR to LLVM

[Martinez, Javier E]

Hi Micah,

I was merging the changes from this commit when I noticed something. The calling convention keyword defined in the lexer doesn't match the definition in the provisional spec [1] on section 3.6. For example, the calling convention 'spirkrnl' is defined as 'spir_kernel'. The host API only allows for loading SPIR binaries which are not affected by this issue. However, being able to load the ascii version is very helpful when debugging. Could you please review the attached patch and commit if ok?

[1] www.khronos.org/registry/cl/specs/spir_spec-1.0-provisional.pdf<http://www.khronos.org/registry/cl/specs/spir_spec-1.0-provisional.pdf>

Thanks,
Javier

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Villmow, Micah
Sent: Friday, September 28, 2012 10:14 AM
To: Villmow, Micah; llvm-commits at cs.uiuc.edu
Cc: Benyei, Guy; Ouriel, Boaz
Subject: Re: [llvm-commits] Patch to add support for SPIR to LLVM

Ping

From: llvm-commits-bounces at cs.uiuc.edu<mailto:llvm-commits-bounces at cs.uiuc.edu> [mailto:llvm-commits-bounces at cs.uiuc.edu]<mailto:[mailto:llvm-commits-bounces at cs.uiuc.edu]> On Behalf Of Villmow, Micah
Sent: Thursday, September 27, 2012 9:39 AM
To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Cc: Benyei, Guy; Ouriel, Boaz
Subject: [llvm-commits] Patch to add support for SPIR to LLVM

I have attached the patch required to support SPIR in LLVM. This patch will allow all vendors who wish to support SPIR as a target the ability to share binaries with the same enums and calling conventions.

The discussion on calling conventions in SPIR is here:
http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-September/053483.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121012/94a906d9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SPIR_AsmParser.patch
Type: application/octet-stream
Size: 1790 bytes
Desc: SPIR_AsmParser.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121012/94a906d9/attachment.obj>