[llvm-commits] [PATCH 7/10] Initial TOC support for PowerPC64 object creation

Adhemerval Zanella azanella at linux.vnet.ibm.com
Thu Oct 11 13:19:37 PDT 2012


On 10/11/2012 04:02 PM, Rafael EspĂ­ndola wrote:
>> Hi Rafael,
>>
>> I added your recommendations and changed the 'checkRelocationUndefined' with a
>> new hook. Is is ok now?
> I provided some feedback on IRC, but I also noticed that the patch can
> be split. For example, would you mind committing just the attached
> patch first? It just adds EmitTCEntry, which is a good, independent,
> improvement.
>
> Cheers,
> Rafael
Ok, I'll. I found out why the testcase failed in your environment: for some reason
the featureBits in the MCSubtargetInfo class creation does not use the mtriple argument,
relying only on the mcpu string or host info to set the target bits. I'm still investigating why, but if you
add -mcpu=ppc64 the testcase passes on a i386 build.




More information about the llvm-commits mailing list