[llvm-commits] [llvm] r165693 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCalls.cpp test/Transforms/InstCombine/struct-assign-tbaa.ll

[Duncan Sands]

Hi Nick,

>>> Don't crash when !tbaa.struct contents is invalid.
>>
>> maybe the verifier should validate this kind of metadata?
>
> Yes, I saw you mention that on the commit where !tbaa.struct was first added. I
> don't have much to add here, other than the verifier currently isn't in the
> business of verifying metadata, even those documented in the LangRef. Should it be?

yes, I think it should verify metadata defined by LLVM (i.e. those documented in
the LangRef), while ignoring metadata invented by users.  It already does a
little bit of metadata verification, in a not very methodical way.

> Even if it were, the code was still missing the null check on the third argument
> as that one is allowed to be null.

OK.

Ciao, Duncan.