[llvm-commits] [llvm] r165708 - in /llvm/trunk: include/llvm/ include/llvm/Analysis/ lib/Analysis/ test/Analysis/DependenceAnalysis/

[Sebastian Pop]

On Thu, Oct 11, 2012 at 2:59 AM, Bill Wendling <wendling at apple.com> wrote:
> Hi Sebastian,
>
> I'm getting this warning. Could you fix it please?
>
> /Volumes/Sandbox/llvm/llvm-clean.src/lib/Analysis/DependenceAnalysis.cpp:1164:32: warning: implicit truncation from 'int' to bitfield changes value from -5 to 3
>       [-Wconstant-conversion]
>     Result.DV[Level].Direction &= ~Dependence::DVEntry::GT;
>                                ^  ~~~~~~~~~~~~~~~~~~~~~~~~
> /Volumes/Sandbox/llvm/llvm-clean.src/lib/Analysis/DependenceAnalysis.cpp:1226:34: warning: implicit truncation from 'int' to bitfield changes value from -5 to 3
>       [-Wconstant-conversion]
>       Result.DV[Level].Direction &= ~Dependence::DVEntry::GT;
>                                  ^  ~~~~~~~~~~~~~~~~~~~~~~~~

I haven't seen this warning in my test: I was building with GCC.
Preston, is this change ok with you?

diff --git a/include/llvm/Analysis/DependenceAnalysis.h
b/include/llvm/Analysis/DependenceAnalysis.h
index 0abf6d8..3a7046d 100644
--- a/include/llvm/Analysis/DependenceAnalysis.h
+++ b/include/llvm/Analysis/DependenceAnalysis.h
@@ -71,12 +71,12 @@ namespace llvm {
       enum { NONE = 0,
              LT = 1,
              EQ = 2,
-             LE = 3,
-             GT = 4,
-             NE = 5,
-             GE = 6,
-             ALL = 7 };
-      unsigned char Direction : 3; // Init to ALL, then refine.
+             LE = 4,
+             GT = 8,
+             NE = 16,
+             GE = 32,
+             ALL = 64 };
+      unsigned char Direction; // Init to ALL, then refine.
       bool Scalar    : 1; // Init to true.
       bool PeelFirst : 1; // Peeling the first iteration will break dependence.
       bool PeelLast  : 1; // Peeling the last iteration will break
the dependence.


Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation