[llvm-commits] TableGen: Goodbye RTTI!

[Sean Silva]

> - The 'kind' enums should be protected, not public.

My reasoning here was that it might be convenient to allow clients to
switch over the enum. This is also what I have documented in
docs/HowToSetUpLLVMStyleRTTI.rst for precisely this reason. Is there a
particular reason you would prefer it to be protected? I'm mostly
interested for the sake of updating the documentation.

-- Sean Silva

On Wed, Oct 10, 2012 at 1:28 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>
> On Oct 9, 2012, at 8:53 PM, Chris Lattner <sabre at nondot.org> wrote:
>
>>
>> On Oct 8, 2012, at 9:10 AM, Sean Silva <silvas at purdue.edu> wrote:
>>
>>> This patch set removes the last traces of RTTI from TableGen (both in
>>> LLVM and Clang) and removes the crutch for enabling RTTI when building
>>> it.
>>
>> This all sounds fine to me, if it's ok with Jakob, go for it!
>
> LGTM with these minor changes:
>
> - The 'kind' enums should be protected, not public.
>
> - The enumerator naming should follow the style guide.
>
> - Don't use funky indentation in the enums.
>
> /jakob
>