[llvm-commits] [PATCH] Fix operand ordering for atomicrmw min/max on ARM

James Molloy James.Molloy at arm.com
Tue Oct 9 00:41:21 PDT 2012


Hi Evan,

I committed it in r164685.

Cheers,

James

On Tue, 2012-10-09 at 01:50 +0100, Evan Cheng wrote:
> Seems obvious. Has this been committed?
>
> Evan
>
> On Sep 25, 2012, at 2:01 AM, James Molloy <James.Molloy at arm.com> wrote:
>
> > Ping.
> >
> > On Fri, 2012-09-21 at 11:25 +0100, James Molloy wrote:
> >> Hi,
> >>
> >> Currently, the code sequences emitted for atomicrmw {umin,umax,min,max}
> >> on ARM are incorrect, because the operands for one of the constituent
> >> instructions are emitted in the wrong order. This causes min to behave
> >> like max and vice versa.
> >>
> >> The attached trivial patch fixes this, and adds some better testing to
> >> check for regression.
> >>
> >> OK to commit?
> >>
> >> Cheers,
> >>
> >> James
> >
> >
> > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.




More information about the llvm-commits mailing list