[llvm-commits] [PATCH][Review Request] Adding isReadOnlyData to SectionRef/ObjectFile interface

[Jim Grosbach]

Minor nits: The patch updates a couple of "Unimplemented" comments to append a period, but introduces a new comment of the same form without the period. The patch should be split to make the cosmetic change separately from the functional change, and the new bit should add the period as well for consistency with the cleanup.

LGTM other than that.

-j


On Oct 5, 2012, at 2:07 PM, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:

> Patch by Ashok Thirumurthi.
>  
> This patch adds new functions to the SectionRef and ObjectFile interfaces to determine whether or not a section is meant to be read-only.  These functions will be used by the MCJIT RuntimeDyld to give hints to the memory manager during the object loading process in a future patch.
>  
> Currently, the functions are only implemented for ELF.  We weren’t 100% certain of the proper implementation for MachO or COFF, so it seemed best to just leave a comment and return ‘false’ which will result in the dynamic loader continuing to behave exactly as it currently does.
>  
> -Andy
> <read-only-sections.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121008/a433ced6/attachment.html>