[llvm-commits] [PATCH] PR 12716: PPC crashes on vector compare

[Hal Finkel]

----- Original Message -----
> From: "Adhemerval Zanella" <azanella at linux.vnet.ibm.com>
> To: llvm-commits at cs.uiuc.edu
> Cc: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>, "Will Schmidt" <willschm at us.ibm.com>, wschmidt at us.ibm.com
> Sent: Tuesday, October 2, 2012 9:42:57 AM
> Subject: [llvm-commits]  [PATCH] PR 12716: PPC crashes on vector compare
> 
> Hi,
> 
> This patch address the PR 12716
> (http://llvm.org/bugs/show_bug.cgi?id=12716). The
> main issue is for vector integer compare using altivec the 'vcmpxxx'
> instruction
> returns a vector register as well, different from integer and
> float-point compare
> where you can specify a CR register.
> 
> With the logic on 'SelectSETCC' that calls 'SelectCC' to get the CR
> register,
> the compare generation fails because it expects a DAG with a CR
> register and get
> a vector register instead.
> 
> This patch changes the behavior by just returning a DAG with the
> vector compare
> instruction based on the type. The patch also adds a testcase for all
> vector
> types llvm defines.
> 
> I also included a fix on signed 5-bits predicates printing, where
> signed values
> were not handled correctly as signed. This generates 'vspltisw'
> (vector splat)
> instruction with SIM out of range. This issue was trigged on the
> testcase.

LGTM. Please include this longer description in the commit message.

 -Hal

> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory