[llvm-commits] [PATCH] PowerPC Vector Floating-Point Rounding

[Hal Finkel]

----- Original Message -----
> From: "Adhemerval Zanella" <azanella at linux.vnet.ibm.com>
> To: llvm-commits at cs.uiuc.edu
> Sent: Monday, October 8, 2012 7:38:53 AM
> Subject: Re: [llvm-commits] [PATCH] PowerPC Vector Floating-Point Rounding
> 
> On 10/06/2012 10:27 AM, Adhemerval Zanella wrote:
> > On 10/05/2012 04:13 PM, Hal Finkel wrote:
> >> ----- Original Message -----
> >> Two quick comments:
> >>
> >>  1. These instructions are not being explicitly marked as Legal in
> >>  PPCISelLowering. I suppose this is the default, but we should
> >>  explicitly mark them as legal for clarity.
> >>
> >>  2. This comments seems oddly worded:
> >>> +// Defines with the UIM field set to 0 to being used on
> >>> floating-point
> >>> +// to integer (fp_to_sint/fp_to_uint) and on integer to
> >>> floating-point
> >>> +// (sint_to_fp/uint_to_fp) conversions.
> >> How's this:
> >>
> >> // Defines with the UIM field set to 0 for floating-point
> >> // to integer (fp_to_sint/fp_to_uint) conversions and integer
> >> // to floating-point (sint_to_fp/uint_to_fp) conversions.
> >>
> >> Otherwise, LGTM.
> >>
> >> Thanks again,
> >> Hal
> > Thanks, I'll mark them explicitly legal on PPCISelLowering.cpp and
> > change the comment.
> >
> How about this one, ok to commit?

LGTM.

Thanks again,
Hal

> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory