[llvm-commits] [LNT] r165172 - in /lnt/trunk/lnt/server: reporting/runs.py ui/templates/reporting/runs.html

Michael Gottesman mgottesman at apple.com
Wed Oct 3 15:05:27 PDT 2012


Author: mgottesman
Date: Wed Oct  3 17:05:27 2012
New Revision: 165172

URL: http://llvm.org/viewvc/llvm-project?rev=165172&view=rev
Log:
lnt.server.reporting.runs: Fixed bug where we were not checking if the baseline was None.

Modified:
    lnt/trunk/lnt/server/reporting/runs.py
    lnt/trunk/lnt/server/ui/templates/reporting/runs.html

Modified: lnt/trunk/lnt/server/reporting/runs.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/runs.py?rev=165172&r1=165171&r2=165172&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/runs.py (original)
+++ lnt/trunk/lnt/server/reporting/runs.py Wed Oct  3 17:05:27 2012
@@ -137,8 +137,11 @@
 
     # Generate prioritized buckets for run over run and run over baseline data.
     prioritized_buckets_run_over_run = prioritize_buckets(test_results)
-    prioritized_buckets_run_over_baseline = prioritize_buckets(baselined_results)
-
+    if baseline:
+        prioritized_buckets_run_over_baseline = prioritize_buckets(baselined_results)
+    else:
+        prioritized_buckets_run_over_baseline = None
+    
     # Prepare auxillary variables for rendering.
     # Create Subject
     subject = """%s test results""" % (machine.name,)

Modified: lnt/trunk/lnt/server/ui/templates/reporting/runs.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/reporting/runs.html?rev=165172&r1=165171&r2=165172&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/reporting/runs.html (original)
+++ lnt/trunk/lnt/server/ui/templates/reporting/runs.html Wed Oct  3 17:05:27 2012
@@ -146,6 +146,7 @@
   }}
 {% endfor %}
 <p>
+{% if baseline %}
 <h3>Run-Over-Baseline Changes Detail</h3>
 {% for _, field, bucket_name, sorted_bucket, test_names, show_perf in prioritized_buckets_run_over_baseline %}
   {% set field_index = ts.sample_fields.index(field) %}
@@ -157,6 +158,7 @@
                                                    'Baseline', '(B)', '', run_to_run_info, styles)
   }}
 {% endfor %}
+{% endif %}
 <hr/>
 <b>Report Time</b>: {{ start_time | timedelta }}
 {% if not only_html_body %}





More information about the llvm-commits mailing list