[llvm-commits] [lld] r164846 - /lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp

[Michael Spencer]

On Wed, Oct 3, 2012 at 12:26 AM, David Blaikie <dblaikie at gmail.com> wrote:
> On Sat, Sep 29, 2012 at 9:22 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> On Sat, Sep 29, 2012 at 12:07 AM, Michael J. Spencer
>> <bigcheesegs at gmail.com> wrote:
>>> Author: mspencer
>>> Date: Fri Sep 28 16:07:58 2012
>>> New Revision: 164846
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=164846&view=rev
>>> Log:
>>> Fix -Wcovered-switch-default warning.
>>>
>>> Modified:
>>>     lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp
>>>
>>> Modified: lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp?rev=164846&r1=164845&r2=164846&view=diff
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp (original)
>>> +++ lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp Fri Sep 28 16:07:58 2012
>>> @@ -40,8 +40,6 @@
>>>      case WriterOptionsMachO::arch_armv7:
>>>        return new KindHandler_arm();
>>>        break;
>
> break after return seems redundant

Yep. Didn't notice that. Thanks.

>
>>> -    default:
>>> -      assert(0 && "arch not supported");
>>
>> Maybe llvm_unreachable?
>
> The presence of a default (regardless of its content) would be what's
> triggering -Wcovered-switch-default. It might be that removing this
> causes a knock-on effect in another compiler (gcc) complaining about a
> missing return - if that's the case, then an llvm_unreachable after
> the switch might be suitable.

If this is warning on gcc that's fine. As long as adding an
enumeration value without updating the switch causes a compile time
error (-Werror) instead of a runtime error.

- Michael Spencer

>
>>
>> Dmitri
>>
>> --
>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits