[llvm-commits] [PATCH] Fix R_ARM_ABS32 JIT relocation

[Kaylor, Andrew]

Why are you using '0x000F0FFF' in the asserts?

Assuming there's a good reason for that, it looks good to me.

I've got a patch that I hope to be committing today that will require a new parameter to the MCJIT tests (-mtriple=%mcjit_triple).  If my patch goes in before yours, please add that.  If yours goes in first, I'll update it.

-Andy

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Amara Emerson
Sent: Tuesday, October 02, 2012 7:06 AM
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Fix R_ARM_ABS32 JIT relocation

Ping.

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Amara Emerson
Sent: 28 September 2012 13:12
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] [PATCH] Fix R_ARM_ABS32 JIT relocation

Hi,

The attached patch fixes the relocation of R_ARM_ABS32 relocs in the RuntimeDyld. The implicit addend in the target relocation address was not being used, resulting in multiple R_ARM_ABS32 relocations having the same final value.

The patch also adds asserts to ensure that there are no unexpected addends for MOVW/MOVT relocations.

A test case is also included in the patch which reproduces the bug.

Regards,
Amara





_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits