[llvm-commits] [PATCH]The ExecutionDepsFix pass does not propagate dependencies through implicit definitions

Jakob Stoklund Olesen stoklund at 2pi.dk
Tue Oct 2 09:07:17 PDT 2012


On Sep 24, 2012, at 6:49 AM, Silviu Baranga <silbar01 at arm.com> wrote:

> Hi,
> 
> The attached patch fixes a problem with the ExecutionDependencyFix pass that
> is causing some execution domain changes to not be performed.
> 
> The visitSoftInstr method does not call setLiveReg for imp-def operands,
> which
> prevents domain collapsing when the dependency is caused by the imp-def
> operand.
> This is because the operand is not considered to be live.
> 
> The attached patch also contains a simple regression test that can be used
> to
> replicate this behaviour.
> 
> Please review.

LGTM.


/jakob




More information about the llvm-commits mailing list