[llvm-commits] [PATCH] Adding the TSVC loop benchmarks to the test suite

[Tobias Grosser]

On 09/27/2012 03:44 AM, Hal Finkel wrote:
> Please review the attached patch which adds the TSVC loop benchmarks to
> the LLVM test suite. These are the benchmarks associated with the paper:
> Maleki, S., et al. An Evaluation of Vectorizing Compilers. PACT'11.

Nice.

> I have adjusted each stage so that the double-precision version takes
> approximately 5 seconds to run on my machine (the float version should
> be faster, but is not always -- one of the reasons it will be good
> have this added). With 18 classes each with double and float variants,
> and assuming that the time for the native binary is comparable to the
> test binary, the entire benchmark should take approximately 360 seconds
> to run. Is that too long?

I believe that is fine. If they run a lot shorter, the timings will be 
very unstable.

> Do I need to do anything special with the fcmp tolerances?

When adding the polybench test cases, the only problem I have seen was 
that NaNs caused problems with textual comparisons as it is written 
differently on OS X and Linux. So better ensure your programs don't 
output NaNs.
Otherwise, I am not aware of any floating point special handling in the 
test suite. I think for now, strict floating point semantics are 
expected. (I am not a test suite expert)

Also, you may want to add reference_out files.

Cheers
Tobi