[llvm-commits] [llvm] r164684 - in /llvm/trunk: lib/Transforms/Utils/SimplifyCFG.cpp test/Transforms/SimplifyCFG/switch_to_lookup_table.ll

[Hans Wennborg]

Committed r164696.

Thanks,
Hans

On Wed, Sep 26, 2012 at 2:38 PM, Duncan Sands <baldrick at free.fr> wrote:
> Hi Hans, thanks for doing this.
>
>> +    assert(isa<IntegerType>(V->getType()) && "Can only ZExt integer
>> values!");
>
> How about: Can only zero extend integer values!

If I do "Can only zero extend ints!", it fits within 80 columns :)

>> +    else if (IntTy->getBitWidth() > DestTy->getBitWidth())
>
> No need for "else" because the previous line returns (style).

Done.

>> +      return CreateTrunc(V, DestTy, Name);
>> +    else
>
> Likewise.

Done.

>
> Analogous comments for the sext version.

Done.