[llvm-commits] LLD ReaderELF reorganized

Sid Manning sidneym at codeaurora.org
Tue Sep 25 12:31:05 PDT 2012


On 09/17/12 14:28, Hemant Kulkarni wrote:
> I am putting the class definitions inside a header so I can access the
> classes and the pointers in other classes.
>
> Please review the reorganization.
>
> --
>
> Hemant Kulkarni
...
>
>   ReaderOptionsELF::ReaderOptionsELF() {
> Index: lib/ReaderWriter/ELF/ReaderELF.h
> ===================================================================
> --- lib/ReaderWriter/ELF/ReaderELF.h	(revision 0)
> +++ lib/ReaderWriter/ELF/ReaderELF.h	(revision 0)

Instead creating a new lib/ReaderWriter/ELF/ReaderELF.h could these 
changes go into the existing include/ldd/ReaderWriter/ReaderELF.h instead?


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation



More information about the llvm-commits mailing list