[llvm-commits] [PATCH] Fix operand ordering for atomicrmw min/max on ARM

[Silviu Baranga]

Hi James,

This looks correct and from my point of view it is OK to commit.

Cheers,
Silviu

> -----Original Message-----
> From: James Molloy
> Sent: 25 September 2012 10:05
> To: Silviu Baranga
> Subject: [Fwd: [llvm-commits] [PATCH] Fix operand ordering for
> atomicrmw min/max on ARM]
> 
> -------- Forwarded Message --------
> From: James Molloy <james.molloy at arm.com>
> To: llvm-commits at cs.uiuc.edu <llvm-commits at cs.uiuc.edu>
> Subject: [llvm-commits] [PATCH] Fix operand ordering for atomicrmw
> min/max on ARM
> Date: Fri, 21 Sep 2012 11:25:23 +0100
> 
> Hi,
> 
> Currently, the code sequences emitted for atomicrmw {umin,umax,min,max}
> on ARM are incorrect, because the operands for one of the constituent
> instructions are emitted in the wrong order. This causes min to behave
> like max and vice versa.
> 
> The attached trivial patch fixes this, and adds some better testing to
> check for regression.
> 
> OK to commit?
> 
> Cheers,
> 
> James