[llvm-commits] [PATCH] unit tests for MCJIT

[Du Toit, Stefanus]

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Jim Grosbach
> Sent: Monday, September 24, 2012 1:38 PM
> To: Malea, Daniel
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH] unit tests for MCJIT
> 
> The most substantive comment is that we shouldn't move the memory
> manager out of lli.cpp. That's very much not a general purpose memory
> manager, but rather is intended as a (trivial) example of what a client
> application may need to implement in order to utilize the MCJIT. It's not
> part of a general LLVM library, but rather part of the lli tool.

What's the downside of moving the memory manager out of lli? If it's sufficient for a simple client (like lli's) needs, why not have it be reusable?

My understanding is that the tests do need *some* memory manager implementation. If it's not moved here, wouldn't it need to be included from inside of the lli sources (awkward) or duplicated somewhere in the test sources (even more awkward)?

Thanks,

Stefanus

--
Stefanus Du Toit stefanus.du.toit at intel.com
  Intel Dynamic Mobility and Parallelism
  Intel Waterloo
  phone: +1 519 772 2576