[llvm-commits] [llvm] r163287 - in /llvm/trunk/lib/Target/Mips: CMakeLists.txt MipsAsmPrinter.cpp MipsDirectObjLower.cpp MipsDirectObjLower.h MipsMCInstLower.cpp MipsMCInstLower.h

[Carter, Jack]

I am back from vacation :-(

I'll look at this today.

Jack
________________________________________
From: Rafael Espíndola [rafael.espindola at gmail.com]
Sent: Thursday, September 20, 2012 11:52 AM
To: Akira Hatanaka
Cc: Carter, Jack; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r163287 - in /llvm/trunk/lib/Target/Mips: CMakeLists.txt MipsAsmPrinter.cpp MipsDirectObjLower.cpp MipsDirectObjLower.h MipsMCInstLower.cpp MipsMCInstLower.h

On 14 September 2012 13:34, Akira Hatanaka <ahatanak at gmail.com> wrote:
> This patch was reviewed internally at mips.
>
> clang actually does print the pseudo when you compile with "-S". The
> function which does the pseudo-to-real expansion is called only if
> OutStreamer.hasRawTextSupport() returns false:
>
> +    if (!OutStreamer.hasRawTextSupport()){
>
>
> But I realize now that perhaps this expansion should happen in
> MCCodeEmitter::EncodeInstruction as you suggest. The purpose of this patch
> was to change the function to do a mcinst-to-mcinst conversion to make it
> available to both direct object emitter and assembler. If the function is
> called in MCCodeEmitter::EncodeInstruction, then that will take care of both
> cases.

Yes, please avoid depending on hasRawTextSupport. MC should handle
cases like this internally. Jack, can you fix this?

Cheers,
Rafael