[llvm-commits] [patch][zorg/clang-tests] Process expected failures within the clang-test execution, instead of on the buildmaster

Eric Christopher echristo at apple.com
Thu Sep 20 14:07:28 PDT 2012


Seems reasonable to me.

-eric

On Sep 20, 2012, at 11:52 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Ping.
> 
> On Thu, Sep 13, 2012 at 4:07 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Here's a rather cheesy attempt to move the logic that ignores expected
>> failures for the clang test suite (specifically for the gdb portion)
>> from the buildbot config (executing on the buildmaster) down into the
>> test suite Makefile (on the slave). This way the ignore list is read
>> live on every execution, instead of just when the buildmaster is
>> reconfigured, and the buildmaster machine doesn't need an extra
>> private checkout of the clang test suite to read the ignore list from.
>> 
>> The fix consists of two parts:
>> 1) zorg.diff, which should be able to be committed separately/ahead of
>> time with no impact: this modifies the builder test running command to
>> be able to handle logs that already have some IGNORE/FLAKY prefixes on
>> test results.
>> 2) clang-tests.diff, which adds a python script (open to other ideas
>> if anyone has them - but this only runs once at the end of the suite
>> execution, so it has a pretty small impact & it's /just/ a bit more
>> complicated than really seemed suitable for sed/awk/bash hackery - at
>> least to me) & a small modification to the GDB suite Makefile to
>> execute the script after runtests is executed & filter the log file
>> in-place, adding the desired "IGNORE" prefixes to any ignored tests.
>> 
>> How's this look? reasonable? If so, once this goes in I'll work on
>> refactoring it further to account for the GCC portion of the suite as
>> well.
> <clang-tests.diff><zorg.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list