[llvm-commits] [PATCH] Define TCLSH variable in the test suite Makefile.config.in

Duncan Sands baldrick at free.fr
Thu Sep 20 05:03:41 PDT 2012


Hi Simon,

> LLVM test suite uses TCLSH variable to point to the tclsh tool. If the
> test suite does not use LLVM's configuration Makefile, this variable
> is explicitly defined in the Makefile.config.in. Otherwise TCLSH
> remains undefined because LLVM's configuration Makefile does not setup
> it. The attached patch fix this problem.
>
> Please review the patch.

in the "else" branch of "ifeq ($(HAS_LLVM),1)" there is:

   TCLSH := tclsh

How about deleting that, and, instead of your patch, add

ifndef TCLSH
TCLSH := tclsh
endif

after the final endif.

Ciao, Duncan.



More information about the llvm-commits mailing list