[llvm-commits] [llvm] r164173 - in /llvm/trunk: include/llvm/Transforms/Utils/IntegerDivision.h lib/Transforms/Utils/CMakeLists.txt lib/Transforms/Utils/IntegerDivision.cpp

[Andrew Trick]

On Sep 19, 2012, at 6:34 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Wed, Sep 19, 2012 at 5:57 PM, Andrew Trick <atrick at apple.com> wrote:
> 
> On Sep 19, 2012, at 5:48 PM, Sean Silva <silvas at purdue.edu> wrote:
> 
> > Could you elaborate on this old-style vs new-style thing? Also, a bit
> > more explanation in the coding standards is probably in order ("older
> > code uses names like ... but the expectation for new code (except
> > where incongruous) is ...".
> 
> 
> I think the Coding Standards already explain the situation well:
> 
> http://llvm.org/docs/CodingStandards.html#introduction
> 
> Michael is working on a file where the function name were still capitalized.
> 
> Er, no, he is adding a brand new file.
> 
> Whether the file existed out-of-tree in some other form shouldn't be relevant here. New code in the LLVM tree is what is held to the coding standards, and this is all new code.


No, there's no other form. I was just thinking of a different file. You're absolutely right, and rereading the thread I see that Michael was pointing out bugs in the coding standard. I'll fix those now.

Thanks.
-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120919/2c3914fb/attachment.html>