[llvm-commits] [PATCH] Adding v*i1 MVTs

Wed Sep 19 15:49:27 PDT 2012

On Wed, 19 Sep 2012 22:41:41 +0000
"Villmow, Micah" <Micah.Villmow at amd.com> wrote:

> Debug only, I'm guessing that when I rebuilt after applying the
> patch, some object files did not get recompiled to the new enums
> correctly, causing a headache.

That's my guess as well. I just rebuilt both Debug and Release and
running 'make check' with both reveals no problems.

 -Hal

> 
> > -----Original Message-----
> > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > Sent: Wednesday, September 19, 2012 3:30 PM
> > To: Villmow, Micah
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [PATCH] Adding v*i1 MVTs
> > 
> > On Wed, 19 Sep 2012 21:49:59 +0000
> > "Villmow, Micah" <Micah.Villmow at amd.com> wrote:
> > 
> > > Actually not just PowerPC, but CellSPU and other tests are
> > > blowing up in PassManager/TargetLowering with memory corruption.
> > 
> > Are you seeing this in a Debug build, Release, or both?
> > 
> >  -Hal
> > 
> > >
> > > Hrmm...
> > >
> > > > -----Original Message-----
> > > > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > > > bounces at cs.uiuc.edu] On Behalf Of Villmow, Micah
> > > > Sent: Wednesday, September 19, 2012 2:16 PM
> > > > To: Hal Finkel
> > > > Cc: llvm-commits at cs.uiuc.edu
> > > > Subject: Re: [llvm-commits] [PATCH] Adding v*i1 MVTs
> > > >
> > > > Ughh, I want to commit this, but PowerPC is blowing up with this
> > > > change.
> > > >
> > > > > -----Original Message-----
> > > > > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > > > > Sent: Tuesday, September 18, 2012 8:51 PM
> > > > > To: Villmow, Micah
> > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > Subject: Re: [PATCH] Adding v*i1 MVTs
> > > > >
> > > > > On Tue, 18 Sep 2012 21:59:12 +0000
> > > > > "Villmow, Micah" <Micah.Villmow at amd.com> wrote:
> > > > >
> > > > > > New patch is attached.
> > > > >
> > > > > LGTM
> > > > >
> > > > > Thanks again,
> > > > > Hal
> > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: llvm-commits-bounces at cs.uiuc.edu
> > > > > > > [mailto:llvm-commits- bounces at cs.uiuc.edu] On Behalf Of
> > > > > > > Villmow, Micah Sent: Tuesday, September 18, 2012 2:37 PM
> > > > > > > To: Hal Finkel
> > > > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > > > Subject: Re: [llvm-commits] [PATCH] Adding v*i1 MVTs
> > > > > > >
> > > > > > > Ahh, yeah I rememeber now, I'll update the patch. We only
> > > > > > > use up
> > > > to
> > > > > > > vec16, not 32 or 64.
> > > > > > >
> > > > > > > Micah
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > > > > > > > Sent: Tuesday, September 18, 2012 2:36 PM
> > > > > > > > To: Villmow, Micah
> > > > > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > > > > Subject: Re: [PATCH] Adding v*i1 MVTs
> > > > > > > >
> > > > > > > > On Tue, 18 Sep 2012 17:48:27 +0000
> > > > > > > > "Villmow, Micah" <Micah.Villmow at amd.com> wrote:
> > > > > > > >
> > > > > > > > > Update patch, had a typo when I was modifying the
> > > > > > > > > patch file
> > > > to
> > > > > > > > > remove unrelated code.
> > > > > > > >
> > > > > > > > Micah,
> > > > > > > >
> > > > > > > > Two things:
> > > > > > > >
> > > > > > > > 1. I think that the consensus from the thread discussing
> > the
> > > > v*i1
> > > > > > > > types with Chris and others was to add only through
> > > > > > > > v16i1 (not v32i1 or v64i1) because no one spoke up with
> > > > > > > > near-term plans to use the 32 or 64-bit types.
> > > > > > > >
> > > > > > > > 2. I had added to include/llvm/Intrinsics.td
> > > > > > > > > +def llvm_v2i1_ty       : LLVMType<v2i1>;     //  2 x
> > > > > > > > > i1 +def llvm_v4i1_ty       : LLVMType<v4i1>;     //
> > > > > > > > > 4 x i1 +def llvm_v8i1_ty       :
> > > > > > > > > LLVMType<v8i1>;     //  8 x i1 +def
> > > > > > > > > llvm_v16i1_ty      : LLVMType<v16i1>;    // 16 x i1
> > > > > > > >
> > > > > > > > Do you have similar additions for your types as well?
> > > > > > > >
> > > > > > > > Thanks again,
> > > > > > > > Hal
> > > > > > > >
> > > > > > > > >
> > > > > > > > > > -----Original Message-----
> > > > > > > > > > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-
> > > > commits-
> > > > > > > > > > bounces at cs.uiuc.edu] On Behalf Of Villmow, Micah
> > > > > > > > > > Sent: Tuesday, September 18, 2012 10:29 AM
> > > > > > > > > > To: Hal Finkel
> > > > > > > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > > > > > > Subject: Re: [llvm-commits] [PATCH] Adding v*i1 MVTs
> > > > > > > > > >
> > > > > > > > > > Here is a patch that adds the new data types. This
> > > > > > > > > > is a combination between my patch for the v16i*
> > > > > > > > > > types and Hal's patch for the v*i1 types.
> > > > > > > > > >
> > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > > > > > > > > > > Sent: Tuesday, September 11, 2012 4:07 PM
> > > > > > > > > > > To: Villmow, Micah
> > > > > > > > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > > > > > > > Subject: Re: [PATCH] Adding v*i1 MVTs
> > > > > > > > > > >
> > > > > > > > > > > On Tue, 11 Sep 2012 15:14:36 +0000 "Villmow,
> > > > > > > > > > > Micah" <Micah.Villmow at amd.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > > > Ping
> > > > > > > > > > >
> > > > > > > > > > > This patch does not add the v*i1 types, only the
> > > > > > > > > > > v*i16, etc. Do you have a patch that adds the v*i1
> > > > > > > > > > > types as
> > > > well?
> > > > > > > > > > >
> > > > > > > > > > > Thanks again,
> > > > > > > > > > > Hal
> > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > > > From: Villmow, Micah
> > > > > > > > > > > > > Sent: Thursday, September 06, 2012 9:48 AM
> > > > > > > > > > > > > To: Villmow, Micah; Hal Finkel
> > > > > > > > > > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > > > > > > > > > Subject: RE: [PATCH] Adding v*i1 MVTs
> > > > > > > > > > > > >
> > > > > > > > > > > > > New patch attached.
> > > > > > > > > > > > >
> > > > > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > > > > From: llvm-commits-bounces at cs.uiuc.edu
> > > > > > > > > > > > > > [mailto:llvm-commits- bounces at cs.uiuc.edu]
> > > > > > > > > > > > > > On
> > > > Behalf
> > > > > > > > > > > > > > Of Villmow, Micah
> > > > > > > > > > > > > > Sent: Saturday, August 25, 2012 8:32 PM
> > > > > > > > > > > > > > To: Hal Finkel
> > > > > > > > > > > > > > Cc: llvm-commits at cs.uiuc.edu
> > > > > > > > > > > > > > Subject: Re: [llvm-commits] [PATCH] Adding
> > > > > > > > > > > > > > v*i1
> > > > MVTs
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > I can look into providing an updated patch
> > > > > > > > > > > > > > to add these in Tuesday if you aren't able
> > > > > > > > > > > > > > to reach that before hand.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Micah
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > > > > > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > > > > > > > > > > > > > > Sent: Friday, August 24, 2012 4:31 PM
> > > > > > > > > > > > > > > To: Villmow, Micah
> > > > > > > > > > > > > > > Cc: llvm-commits at cs.uiuc.edu; Heikki
> > > > > > > > > > > > > > > Kultala Subject: Re: [PATCH] Adding v*i1
> > > > > > > > > > > > > > > MVTs
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On Fri, 3 Aug 2012 20:02:38 +0000
> > > > > > > > > > > > > > > "Villmow,
> > > > Micah"
> > > > > > > > > > > > > > > <Micah.Villmow at amd.com> wrote:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > Hal,
> > > > > > > > > > > > > > > >  That sounds good. I won't be able to do
> > any
> > > > > > > > > > > > > > > > combining until next Tuesday, so if you
> > > > > > > > > > > > > > > > want to merge them and submit together I
> > > > > > > > > > > > > > > > have no issue with it.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Were you doing this, or was I? I think
> > > > > > > > > > > > > > > that based on the exchange with Chris and
> > > > > > > > > > > > > > > Heikki we're sticking to just adding
> > > > > > > > > > > > > > > v2i1, v4i1, v8i1 for
> > > > > > > > > > > > > > now.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Thanks again,
> > > > > > > > > > > > > > > Hal
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > The patch itself looks fine to me.
> > > > > > > > > > > > > > > > Micah
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > > > > > > > From: Hal Finkel
> > > > > > > > > > > > > > > > > [mailto:hfinkel at anl.gov] Sent:
> > > > > > > > > > > > > > > > > Friday, August 03, 2012 12:46 PM To:
> > > > > > > > > > > > > > > > > llvm-commits at cs.uiuc.edu; Villmow,
> > > > > > > > > > > > > > > > > Micah; Heikki Kultala Subject:
> > > > > > > > > > > > > > > > > [PATCH] Adding v*i1 MVTs
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > Please review the attached patch which
> > > > > > > > > > > > > > > > > adds
> > > > > v*i1
> > > > > > > MVTs.
> > > > > > > > > > > > > > > > > I need these for properly representing
> > the
> > > > > > > > > > > > > > > > > output of vectorized selects and
> > > > > > > > > > > > > > > > > boolean operations on the BG/Q
> > > > > > > > > > > > > > > > > supercomputer
> > (v4i1
> > > > > > > > > > > > > > specifically).
> > > > > > > > > > > > > > > > > As others have also expressed an
> > > > > > > > > > > > > > > > > interest in these, and in the name of
> > > > > > > > > > > > > > > > > limiting the number
> > > > > of
> > > > > > > > > > > > > > > > > renumbering patches, this patch adds
> > > > > > > > > > > > > > > > > v2i1 through
> > > > > > > v64i1.
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > Heikki, will this meet your needs as
> > well?
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > Micah, this patch obviously affects
> > > > > > > > > > > > > > > > > the same renumbering as your <2 x
> > > > > > > > > > > > > > > > > [i8|i16]> patch.
> > > > Maybe
> > > > > > > > > > > > > > > > > we should combine
> > > > > > > > > > them?
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > Thanks again,
> > > > > > > > > > > > > > > > > Hal
> > > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > > Hal Finkel
> > > > > > > > > > > > > > > > > Postdoctoral Appointee Leadership
> > > > > > > > > > > > > > > > > Computing Facility Argonne National
> > > > > > > > > > > > > > > > > Laboratory
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > Hal Finkel
> > > > > > > > > > > > > > > Postdoctoral Appointee
> > > > > > > > > > > > > > > Leadership Computing Facility Argonne
> > National
> > > > > > > > > > > > > > > Laboratory
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > _______________________________________________
> > > > > > > > > > > > > > llvm-commits mailing list
> > > > > > > > > > > > > > llvm-commits at cs.uiuc.edu
> > > > > > > > > > > > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-
> > > > > commits
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Hal Finkel
> > > > > > > > > > > Postdoctoral Appointee
> > > > > > > > > > > Leadership Computing Facility
> > > > > > > > > > > Argonne National Laboratory
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Hal Finkel
> > > > > > > > Postdoctoral Appointee
> > > > > > > > Leadership Computing Facility
> > > > > > > > Argonne National Laboratory
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > llvm-commits mailing list
> > > > > > > llvm-commits at cs.uiuc.edu
> > > > > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Hal Finkel
> > > > > Postdoctoral Appointee
> > > > > Leadership Computing Facility
> > > > > Argonne National Laboratory
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > llvm-commits mailing list
> > > > llvm-commits at cs.uiuc.edu
> > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > >
> > >
> > 
> > 
> > 
> > --
> > Hal Finkel
> > Postdoctoral Appointee
> > Leadership Computing Facility
> > Argonne National Laboratory
> 
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory