[llvm-commits] [llvm] r164216 - /llvm/trunk/lib/Transforms/Utils/IntegerDivision.cpp

Benjamin Kramer benny.kra at googlemail.com
Wed Sep 19 06:03:07 PDT 2012


Author: d0k
Date: Wed Sep 19 08:03:07 2012
New Revision: 164216

URL: http://llvm.org/viewvc/llvm-project?rev=164216&view=rev
Log:
IntegerDivision: Style cleanups, avoid warning about mixing || and && without parens.

Modified:
    llvm/trunk/lib/Transforms/Utils/IntegerDivision.cpp

Modified: llvm/trunk/lib/Transforms/Utils/IntegerDivision.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/IntegerDivision.cpp?rev=164216&r1=164215&r2=164216&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/IntegerDivision.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/IntegerDivision.cpp Wed Sep 19 08:03:07 2012
@@ -266,16 +266,14 @@
 }
 
 bool llvm::expandDivision(BinaryOperator* Div) {
-  assert(Div->getOpcode() == Instruction::SDiv ||
-         Div->getOpcode() == Instruction::UDiv
-         && "Trying to expand division from a non-division function");
+  assert((Div->getOpcode() == Instruction::SDiv ||
+          Div->getOpcode() == Instruction::UDiv) &&
+         "Trying to expand division from a non-division function");
 
   IRBuilder<> Builder(Div);
 
-  if (Div->getType()->isVectorTy()) {
-    assert(0 && "Div over vectors not supported");
-    return false;
-  }
+  if (Div->getType()->isVectorTy())
+    llvm_unreachable("Div over vectors not supported");
 
   // First prepare the sign if it's a signed division
   if (Div->getOpcode() == Instruction::SDiv) {





More information about the llvm-commits mailing list