[llvm-commits] [llvm] r164181 - /llvm/trunk/lib/MC/MachObjectWriter.cpp

[Sean Silva]

In this function (MachObjectWriter::WriteObject), is
`Layout.getAssembler()` the same as the `Asm` argument?

If so, then you can just use `&Asm.getSymbolData(...)` and avoid
breaking the lines. If not, then I think it ought to be explained
("here we have to use Layout.getAssembler() instead of Asm
because...").

--Sean Silva

On Tue, Sep 18, 2012 at 7:05 PM, Jim Grosbach <grosbach at apple.com> wrote:
> Author: grosbach
> Date: Tue Sep 18 18:05:12 2012
> New Revision: 164181
>
> URL: http://llvm.org/viewvc/llvm-project?rev=164181&view=rev
> Log:
> Tidy up. 80 columns.
>
> Modified:
>     llvm/trunk/lib/MC/MachObjectWriter.cpp
>
> Modified: llvm/trunk/lib/MC/MachObjectWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MachObjectWriter.cpp?rev=164181&r1=164180&r2=164181&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/MachObjectWriter.cpp (original)
> +++ llvm/trunk/lib/MC/MachObjectWriter.cpp Tue Sep 18 18:05:12 2012
> @@ -820,8 +820,12 @@
>           it = Asm.data_region_begin(), ie = Asm.data_region_end();
>           it != ie; ++it) {
>      const DataRegionData *Data = &(*it);
> -    uint64_t Start = getSymbolAddress(&Layout.getAssembler().getSymbolData(*Data->Start), Layout);
> -    uint64_t End = getSymbolAddress(&Layout.getAssembler().getSymbolData(*Data->End), Layout);
> +    uint64_t Start =
> +      getSymbolAddress(&Layout.getAssembler().getSymbolData(*Data->Start),
> +                       Layout);
> +    uint64_t End =
> +      getSymbolAddress(&Layout.getAssembler().getSymbolData(*Data->End),
> +                       Layout);
>      DEBUG(dbgs() << "data in code region-- kind: " << Data->Kind
>                   << "  start: " << Start << "(" << Data->Start->getName() << ")"
>                   << "  end: " << End << "(" << Data->End->getName() << ")"
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits