[llvm-commits] LLD ReaderELF reorganized

Sean Silva silvas at purdue.edu
Tue Sep 18 11:35:19 PDT 2012


Sorry for the tangent, but I just saw this FIXME in the code (it was
just being moved, so this is unrelated to the patch at hand):

+  //   FIXME   Need to revisit this in future.
+

Please include *why* this needs to be revisited. FIXME by definition
means that it needs to be revisited, so this is basically no different
than saying just FIXME, without telling what the "ME" is that needs to
be "FIX"ed.

--Sean Silva

On Mon, Sep 17, 2012 at 3:28 PM, Hemant Kulkarni <khemant at codeaurora.org> wrote:
> I am putting the class definitions inside a header so I can access the
> classes and the pointers in other classes.
>
> Please review the reorganization.
>
>
>
> --
>
> Hemant Kulkarni
>
> khemant at codeaurora.org
>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> the Linux Foundation
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list