[llvm-commits] [PATCH] Fix ARM MCJIT icache invalidation

Jim Grosbach grosbach at apple.com
Tue Sep 18 11:29:08 PDT 2012


Hi Amara,

I don't believe I saw this patch go by the first time. Thanks for bringing it to my attention. I'll have a look!

-Jim

On Sep 18, 2012, at 6:06 AM, Amara Emerson wrote:

> Ping. Jim, could you take a look at this? There was a patch for review a
> while ago which may conflict with this one (refactoring parts of lli and
> adding MCJIT tests).
> 
> This bug is causing severe problems on ARM.
> 
> Amara
> 
> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu
> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Amara Emerson
> Sent: 10 September 2012 15:47
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] [PATCH] Fix ARM MCJIT icache invalidation
> 
> Hi,
> 
> I've fixed a bug in lli/MCJIT which causes the icache invalidation to have
> no effect, causing segfaults on ARM. This patch affects the MCJIT and the
> memory manager interfaces. Icache invalidation is now called by default in
> MCJIT instead of explicitly in lli.
> 
> This fixes random segfaults in ExecutionEngine/MCJIT/test-common-symbols.ll
> (and it seems other ARM MCJIT failing tests as well).
> 
> Regards,
> Amara
> 
> 




More information about the llvm-commits mailing list